In the Linux kernel, the following vulnerability has been resolved:
vlan: fix skb_under_panic and races when toggling HW VLAN offload
Toggling hardware VLAN TX offload (NETIF_F_HW_VLAN_CTAG_TX or NETIF_F_HW_VLAN_STAG_TX) on a lower device invokes vlan_transfer_features(), which dynamically changed vlandev->hard_header_len.
This causes two issues:
- Lockless TX paths (e.g. packet_snd in af_packet.c, ip6_finish_output2)
- In addition, vlan_transfer_features() updated hard_header_len without
Always setting dev->hard_header_len = real_dev->hard_header_len and dev->needed_headroom = real_dev->needed_headroom + VLAN_HLEN unconditionally ensures:
- dev->hard_header_len remains 100% static and immutable at real_dev->hard_header_len,
- Upper layers allocating skbs via LL_RESERVED_SPACE() will always reserve
- vlandev inherits real_dev->needed_tailroom so underlying trailer/padding/ICV
- AF_PACKET SOCK_RAW network header offsets remain correctly aligned at
- vlan_header_ops is used unconditionally.
Note to stable teams: Make sure to backport these commits:
e16e960d55a4 ("ipvlan: inherit needed_headroom and needed_tailroom from phy_dev") cef51860becd ("macvlan: inherit needed_headroom and needed_tailroom from lowerdev")